Duplication of URL paramaters

Created on 1 June 2022, over 2 years ago
Updated 12 September 2023, about 1 year ago

Problem/Motivation

Parameters of the faceted search are duplicated, same issue as https://www.drupal.org/project/facets_pretty_paths/issues/3254600 🐛 Cannot filter properly when using facet pretty paths Fixed , also the same soluction of patch on #13 fix the issue.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain cimo75

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇸🇮Slovenia alecsmrekar

    Here's an alternative patch that does the same, but can be way faster. The patch in #2 works fine, but it require quite a bit of processing power to run all the Url:: calls.

    So this code does the same, but it allows you to specify $settings['facets_short_pretty_paths_search_page_route'] = 'your_search_route'; which speeds up the facet rendering, especially if you have a lot of terms rendered on the page.

  • Status changed to Needs review over 1 year ago
  • 🇮🇹Italy plach Venezia

    Looks good and works well here, we may need some documentation if this approach is deemed valid.

    • 08f40afa committed on 1.0.x
      Issue #3283691 by alecsmrekar, campbellt_, cimo75, proweb.ua, colorfield...
  • Status changed to Fixed about 1 year ago
  • 🇨🇭Switzerland colorfield Lausanne

    Thanks all, finally used the same resolution as https://www.drupal.org/project/facets_pretty_paths/issues/3254600#commen... 🐛 Cannot filter properly when using facet pretty paths Fixed

    Approach from #5 looks great, but we might want a bit more flexibility here for multiple routes and probably get this from the configuration as it can be tricky to maintain for non devs. So we could discuss this in a follow-up.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024