Add option to hide exposed field labels

#3 works.

Will need some kind of update hook for existing sites.

Added an update hook thoughts?

Thanks for working on this issue. I have a use case for this functionality in one of my projects, so I did a quick review. Unfortunately, I noticed an issue with the update hook. I confirmed that the update hook probably doesn't work as intended on a patched BEF 6.0.5 on Drupal 10.2.6. Since we're touching the code again anyway, I also added some rather nitpicky stuff as well, which is totally optional.

@feyp not sure I follow the suggestions? Do you want to add them to the MR?

FeyP → changed the visibility of the branch 3282228-add-option-to to hidden.

FeyP → changed the visibility of the branch 3282228-add-option-to to active.

@smustgrave Sure. I pushed a new branch for 7.0.x to the fork and updated the code there to address my review. New MR for 7.0.x is MR 82. I also rebased MR 6.0.x and cherry-picked my commits there, pushed everything to MR 72, which is still for 6.0.x.

I tested the update hook on Drupal 10.3.0 with the 7.0.x MR and I think it works as intended now. Note that I didn't re-test the 6.0.x MR after my changes, although I don't see how this shouldn't work.

I added the string change for the description as a separate commit so you can easily revert it, if you don't agree with that one. Unfortunately, it looks like I don't have permission to resolve my own review comments on the MR 72, so they're still open.

Here is a config export after the update hook with a single BEF view, only change was this one, just as intended:

--- a/sync/views.view.better_exposed_filters_issue_3282228.yml
+++ b/sync/views.view.better_exposed_filters_issue_3282228.yml
@@ -124,6 +124,7 @@ display:
                   collapsible: false
                   collapsible_disable_automatic_open: false
                   is_secondary: false
+                  hide_label: false
                 select_all_none: false
                 select_all_none_nested: false
                 display_inline: true

smustgrave → closed merge request !74

smustgrave → closed merge request !82

Automatically closed - issue fixed for 2 weeks with no activity.