PoItem::formatSingular doesn't add linebreak on untranslated strings

$untranslated = new PoItem(); $untranslated->setSource(""); // msgid "" // msgstr "" $untranslated->__toString(): $translated = new PoItem(); $translated->setSource(""); $translated->setTranslation(""); // msgid "" // msgstr "" // $translated->__toString();

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
Comment 2 months ago →
🇺🇸United States smustgrave
having a terrible time rebasing this lol
@andypost opened merge request.
Comment 2 months ago →
🇫🇷France andypost
Used to run test for 11.x and cherry-picked commit from previous MR (thanks smustgrave for 9.5)
Comment 2 months ago →
🇺🇸United States smustgrave
Think this looks good now
Comment 12 days ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
There's so much odd code in this class...

foreach ($this->translation as $i => $trans) { if (isset($this->translation[$i])) { $output .= 'msgstr[' . $i . '] ' . $this->formatString($trans); } else { $output .= 'msgstr[' . $i . '] ""' . "\n"; } }
Afaics if (isset($this->translation[$i])) { must be true. I'm not even sure what that code is try to do... - maybe handle the case where one of the plural forms is not translated.

Anyhow this fix is fine.

Comment 12 days ago →

System Message

alexpott → committed be9783de on 11.x

Issue #3278481 by andypost, gapple, smustgrave: PoItem::formatSingular...

Comment 12 days ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Going to commit to 11.x only as I don;t see why po files should change in a patch release. It's not like this is causing any real bugs.

Committed be9783d and pushed to 11.x. Thanks!

PoItem::formatSingular doesn't add linebreak on untranslated strings

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities