Don't assume a request has an authorization header

Created on 3 May 2022, almost 3 years ago
Updated 27 December 2023, about 1 year ago

Problem/Motivation

If a request doesn't have an authorization header, the code in line 40 of src/OAuth2Helper triggers a warning.

Steps to reproduce

Checkout current 2.0.0 dev, don't configure oauth2 server but enable it. Visit a URL.

Proposed resolution

Modify to check for a NULL header value before using trim on it.

Remaining tasks

PR coming.

User interface changes

Nil

API changes

Nil

Data model changes

Nil

πŸ› Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia nigelcunningham Geelong

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024