- 🇩🇪Germany rkoller Nürnberg, Germany
The issue still applies to 10.1.x (tested on Safari, Firefox and Edge on MacOS). I've attached a brief video to illustrate the issue switching between the horizontal and vertical toolbar. But i think the component should be set to olivero and not claro since the region preview is shown in the default theme? and in regards of olivero it looks like when the admin toolbar is set to the vertical orientation the
position: fixed
on theexit block region demonstration
link is the reason why it stays hidden behind the toolbar? - 🇩🇪Germany rkoller Nürnberg, Germany
...or maybe i was a little bit premature. i've switched the default theme to claro afterwards. the issue applies there as well. different layout but the problem in general is the same. so would the component in concern be the
block
module instead wherefunction block_page_top
is located which contains the backlink that is hidden by the vertical admin toolbar? - 🇮🇳India Gauravvv Delhi, India
Gauravvvv → made their first commit to this issue’s fork.
- @gauravvvv opened merge request.
- Status changed to Needs review
over 1 year ago 4:25am 14 March 2023 - Status changed to Needs work
over 1 year ago 11:51am 14 March 2023 - 🇩🇪Germany rkoller Nürnberg, Germany
Thanks @gauravvvv for working on a fix! I've applied the patch and tested the following details:
- first with the admin_toolbar module installed i've tested in olivero. the exit block is shown. the only detail is that when the admin_toolbar is set to the vertical toolbar there is a horizontal scrollbar. but that happens without the patch applied in olivero as well.
- with claro as default theme that scrolling doesnt happen and the exit block is displayed in the same way like with olivero.
- same for the bootstrap barrio 5 theme. there only the skip to main content link is also shown. but that is an issue with the barrio theme. but the functionality of the exit block region demonstration link is reachable.the fix works and it straight forward and easy. nice! the only detail i wonder if it would make sense (or if it is even necessary) to add a test to check if the link is visible and not covered and hidden by any other element? i am just not sure if you use
isVisible
in nightwatch if that is checking if the element is visible and not something likedisplay: none
. is applied or ifisVisible
actually tests if an element is in the visible viewport and not covered nor hidden? i'll set the status to needs work. in case a test isn't necessary here i would consider the issue RTBC and could be changed to that.and since the patch changes code within the block module only, i'll change the component to the block module also.