Unneccesary nav-link class on local task nav-item

Created on 27 April 2022, over 2 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

An active local task gets the "nav-link" class on its surround nav-item (li tag). Looking at bootstrap reference implemtation of navs and tabs, this seems wrong.

Steps to reproduce

Check the active item in a nav tab element in bootstrap5 theme (e. g. the view tab of the node operations when logged in). The view tab is the active tab and it does get the "nav-link" class as well as the "nav-item" class on its surrounding li-tag.

Proposed resolution

do not add nav-link class to the surrounding element

Remaining tasks

create a patch

User interface changes

Active tab implementation will be more in line with bootstrap reference implementation

API changes

none

Data model changes

none

πŸ› Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany stefan.korn Jossgrund

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024