Contrib.social

Support Drupal 10 and update all use of deprecation in the Autocomplete Deluxe module

Open on Drupal.org →
Created on 27 April 2022, about 2 years ago
Updated 6 February 2023, over 1 year ago

Problem/Motivation

Drupal 10.0.0 stable was released on: 15 Dec 2022 by the Drupal core team
https://www.drupal.org/project/drupal/releases/10.0.0 →

Thank you so much!

The current composer require status for this module under Drupal 10

composer create-project drupal/recommended-project:~10.0 /var/www/html/sandboxes/drupal10autocomplete_deluxe
cd /var/www/html/sandboxes/drupal10autocomplete_deluxe/

composer config minimum-stability dev

composer require drupal/autocomplete_deluxe;

Further drupal-check on

composer require drupal/core-dev --with-all-dependencies
composer require mglaman/drupal-check --dev
composer require phpspec/prophecy-phpunit:^2 --dev 

php vendor/bin/drupal-check -d web/modules/contrib/autocomplete_deluxe/

Output:

autocomplete_deluxe--drupal-check--report.txt → 

 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

Proposed resolution

  • Support Drupal ~10 and change all deprecated packages, classes, functions, asset libraries to the Drupal 10 way
  • Real physical testing with Drupal ~10
  • Automated upgrade to Drupal ~10

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ✅ UX/UI designer responsibilities
  • ✅ Readability
  • ✅ Accessibility
  • ✅ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release autocomplete_deluxe-2.0.3 →

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

📌 Task
Status

Fixed

Version

2.0

Component

Code (miscellaneous)

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Comment over 1 year ago →
    🇳🇴Norway eiriksm Norway

    Hey there!

    Thanks for your work on this. Just wanted to point out that with this issue resolved and released, this module is no longer compatible with drupal 8. Of course, Drupal 8 is not even supported, but it would be nice to also indicate this on the module page, composer.json file and info file. If people were to upgrade right now (which it does seem like they can) their autocomplete things will certainly start working (since the once library only exists in drupal 9).

    At this point it's unfortunately too late to mark the release 2.0.3 as not supported in drupal 8, but I would recommend doing so from now on, so the next release will be marked as such.

    Do you want me to open a new issue / merge request for this?

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024