Quick Edit revision references wrong author

Created on 20 April 2022, almost 3 years ago

Updated 4 May 2023, almost 2 years ago

Problem/Motivation

When using quick edit to make changes on a revisionable node, the author of the quick edit revision is wrong.

Steps to reproduce

Create a node with user 1.
Logout of the site and login with user 2.
Use quick edit to change something on the node created by user 1, e.g the body field
Go the revisions tab of the node and check the author of the revision. It will be user 1 instead of user 2.

Proposed resolution

In QuickEditFieldForm.php in the init function where the entity is prepared with $entity->setNewRevision($node_type->shouldCreateNewRevision()); another call is needed after to set the revision's user id $entity->setRevisionUserId($this->currentUser->id());.

Remaining tasks

Write test that proves the issue.
Provide patch that fixes the issue.

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇨🇦Canada pavlosdan

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
78 pass, 8 fail
@basvredeling opened merge request.
Status changed to Needs review almost 2 years ago10:13am 4 May 2023
Comment almost 2 years ago →
🇳🇱Netherlands basvredeling Amsterdam
MR in #6 needs a review. It's a re-roll of the Drupal core patch in #3.
Comment about 2 months ago →
🇫🇷France Paulmicha Porto Alegre, RS, Brasil
On top of $entity->setRevisionUserId($this->currentUser->id()); it also needs a $entity->setRevisionCreationTime(time()); otherwise the revision is stuck on the previous modification date.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024