Contrib.social

Theme's generated from starter kit need to remove "starterkit: true"

Open on Drupal.org →
Created on 17 April 2022, over 2 years ago
Updated 29 January 2023, almost 2 years ago

Problem/Motivation

When generating a new theme, the starterkit: true value passes along from the original Starterkit. This should be removed.

name: 'My theme'
type: theme
'base theme': stable9
libraries:
  - mytheme/base
  - mytheme/messages
  - core/normalize

This was an oversight from #3206219: Allow configuring which theme is used as a starterkit theme →

Steps to reproduce

Run the following, review info.yml

php core/scripts/drupal generate-theme mytheme --name "My theme"

Proposed resolution

Strip out starterkit when generating a theme

    $info = Yaml::decode(file_get_contents($info_file));
    $info['name'] = $input->getOption('name') ?: $destination_theme;

    // Unhide hidden themes.
    unset($info['hidden']);

+    // Remove `starterkit` flag.
+    unset($info['starterkit']);

    $info['core_version_requirement'] = '^' . $this->getVersion();

Remaining tasks

1. Test it!
2. Fix it!

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs work

Version

10.1 ✨

Component
Starterkit  →

Last updated about 1 month ago

No maintainer
Created by

🇺🇸United States mglaman WI, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇨🇦Canada joelpittet Vancouver

    I actually wanted this to stay, there is two use-cases:

    1. Basing your theme off a starterkit (most common, probably why this issue exists)
    2. Basing your starterkit off a starterkit

    We are trying to do this with Basic theme 🌱 Basic 3.0 Roadmap Active

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024