Add save to library link to the built section preserve array key

Created on 15 April 2022, over 2 years ago

Updated 22 January 2024, 10 months ago

In SectionLibraryRender.php you do:

$last_item_section = array_pop($sections[$key]);

This will pop the lost item of the array in my case:
['layout-builder__section' => [allSections]

Propose to preserve array key

Patch attached.

Review & double test/check

🐛 Bug report

Status

RTBC

Version

1.0

Component

Code

Created by

🇧🇪Belgium Mschudders

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
Waiting for branch to pass
Comment about 1 year ago →
🇧🇪Belgium kriboogh
Tested, applies and works (been using it in production for over a year now).
MR diff added for use in composer.
Comment 10 months ago →
🇺🇸United States kevinquillen
Seems related to 🐛 Do not use array_pop or array_push Needs review
Comment 10 months ago →
🇺🇸United States kevinquillen

Production build 0.71.5 2024