Only add the fields on Image media embeds, not all

Created on 13 April 2022, about 2 years ago

Updated 19 April 2023, about 1 year ago

If your site is allowing more media types to be embedded in the ckeditor (file, video, etc), the width and height fields are always being added to the embed edit media form. Based on the corresponding `applyPerEmbedMediaOverrides` method in the `MediaEmbed` class, the width and height settings will only apply to image media entities, so we should only show them on the form when it's an image media entity.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇨🇦Canada porchlight

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
@ericmaster opened merge request.
Comment over 1 year ago →
System Message

porchlight → authored 2decae31 on 1.0.x
Issue #3275118 by porchlight: Only add the fields on Image media embeds...
Status changed to Fixed over 1 year ago2:33am 5 April 2023
Comment over 1 year ago →
🇪🇨Ecuador Ericmaster
Patch applied! Thanks for the contribution.
Comment over 1 year ago →
🇪🇨Ecuador Ericmaster
Status changed to Fixed about 1 year ago2:34am 19 April 2023
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024