Don't bother with file copies during build, keep file paths on the build and deploy from the original file

First a re-roll

The last submitted patch, 8: 3271913-8.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

New approach, no interdiff as its a do-over

The last submitted patch, 11: 3271913-2.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Allow for subdirectory on test-bot

The last submitted patch, 15: 3271913-10.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Take two

--- a/modules/preview_site_s3/src/Plugin/PreviewSite/Deploy/S3.php
+++ b/modules/preview_site_s3/src/Plugin/PreviewSite/Deploy/S3.php

@@ -269,4 +269,32 @@ class S3 extends DeployPluginBase implements ContainerFactoryPluginInterface {
+  public function deployFilePath(PreviewSiteBuildInterface $build, string $path): void {

This is almost identical to deployArtifact

Can we reafctor that so it calls this with FileHelper::getFilePathWithoutSchema($file, $build) as the path?

Otherwise looking pretty good, great idea!

Can we reafctor that so it calls this with FileHelper::getFilePathWithoutSchema($file, $build) as the path?

I considered it, but was on the fence, but having another vote for doing it helps sway me towards it. Will do!

Made that change and fixed some PHPCS while I was at it

I mentioned this to @larowlan, but this has also solved OOM issues with the preview site build form - during validation it was validating the entity reference for all artifacts.

Cutting a new release with this

Hello,

I'm reopening this issue, because I'm experiencing a PHP Fatal Error.

Here's a part of the stack trace:

 Error: Call to undefined method Drupal\preview_site\Generate\TomeStaticExtension::getJavascriptModules() in /opt/drupal/web/modules/contrib/preview_site/src/Generate/TomeStaticExtension.php:185 Stack trace: 
#0 /opt/drupal/web/modules/contrib/preview_site/src/Plugin/PreviewSite/Generate/TomeGenerator.php(207): Drupal\preview_site\Generate\TomeStaticExtension->exportPaths(Array) 
#1 /opt/drupal/web/modules/contrib/preview_site/src/Plugin/PreviewSite/Generate/TomeGenerator.php(129): Drupal\preview_site\Plugin\PreviewSite\Generate\TomeGenerator->generateBuildForPath(Object(Drupal\preview_site\Entity\PreviewSiteBuild), '_entity:node:en...', 'http://default/...', Object(Drupal\Core\Queue\DatabaseQueue)) 
#2 /opt/drupal/web/modules/contrib/preview_site/src/Plugin/QueueWorker/Generate.php(115): Drupal\preview_site\Plugin\PreviewSite\Generate\TomeGenerator->generateBuildForItem(Object(Drupal\preview_site\Entity\PreviewSiteBuild), Object(Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem), 'http://default/...', Object(Drupal\Core\Queue\DatabaseQueue)) 
#3 /opt/drupal/web/modules/contrib/preview_site/src/PreviewSiteBuilder.php(180): Drupal\preview_site\Plugin\QueueWorker\Generate->processItem(0) 
#4 /opt/drupal/web/modules/contrib/preview_site/src/PreviewSiteBuilder.php(120): Drupal\preview_site\PreviewSiteBuilder->processQueueItem('preview_site_ge...') 
#5 /opt/drupal/web/modules/contrib/preview_site/src/PreviewSiteBuilder.php(242): Drupal\preview_site\PreviewSiteBuilder->processSiteGeneration(Object(Drupal\preview_site\Entity\PreviewSiteBuild)) 
#6 /opt/drupal/packages/languagewire_tmgmt_connector/src/Adapter/PreviewSite/PreviewSiteBuilder.php(66): Drupal\preview_site\PreviewSiteBuilder::operationProcessGenerate(303, Array)
(...)

I've taken a look at the preview_site module source code, and I indeed can find the "getJavascriptModules()" method definition nowhere in there.

This issue was introduced in the release 1.1.5 of the module.

PS. This is my first time adding a comment in Drupal's issue tracker. Please forgive me if I should have opened a new issue instead.

You're right, that function is provided by https://www.drupal.org/project/tome/issues/3230078 ✨ Add support for Javascript modules Fixed

I'm surprised tests are passing...

@acbramley There isn't test coverage for it. Do we remove the patch for now and roll a new release until the dependency is merged in?

I've reverted the commit and published 1.1.6

Great @acbramley!

Let's try and push that one forward then

The tome issue is fixed/released so here's a new patch with a minimum requirement on that version of tome

Awesome! RTBC assuming green :)

Ran the tests locally, as something not right with drupalci, the folder is missing 🤔

phpunit -c app/core app/modules/preview_site --stop-on-failure
⏳️ Bootstrapped tests in 0 seconds.
🐘 PHP Version 8.1.16.
💧 Drupal Version 9.5.8-dev.
🗄️  Database engine mysql.
PHPUnit 9.6.6 by Sebastian Bergmann and contributors.

Testing /data/app/modules/preview_site
................................................................. 65 / 66 ( 98%)
.                                                                 66 / 66 (100%)

Time: 03:17.707, Memory: 18.00 MB

OK (66 tests, 1615 assertions)

Automatically closed - issue fixed for 2 weeks with no activity.