Contrib.social

Add block type to the list and to the filters

Open on Drupal.org →
Created on 23 March 2022, almost 3 years ago
Updated 8 August 2023, over 1 year ago

Problem/Motivation

It's difficult to understand the block type filters without the 'admin label' of them.
So would be great to show that label instead if it is not empty.

Also to make sense of this change we need to add the same type label to the list.

And since we have more than inline_blocks and paragraphs, there should be a filter for the rest of block types.

Steps to reproduce

Install the module and go to 'admin/reports/layout/usage'.

Proposed resolution

Use the 'admin label' of the block type on the filters.
Add a filter for the rest of the blocks not filtered right now.
Add the type to the list of blocks.

Remaining tasks

User interface changes

Add on more column and one extra filter.

API changes

None

Data model changes

None

✨ Feature request
Status

Needs review

Version

1.0

Component

User interface

Created by

🇪🇸Spain edurenye

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • @edurenye opened merge request.
  • Comment over 1 year ago →
    🇺🇸United States chrissnyder Maryland

    I was able to use this patch on Drupal 10.1.

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States chrissnyder Maryland
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇺🇸United States justcaldwell Austin, Texas

    Thanks for the contribution! In general, I like the changes proposed here. I think there are some minor issues that need discussion/work:

    1. In the filters, what was labeled 'Block Type' is now 'Inline Block Type' and 'Block Type' now refers to other or reusable blocks, is that correct? This was confusing to me. Maybe 'Other Block Type' or 'Reusable Block Type' would be a better label here? I'm not sure.
    2. If I'm correct above, then those two filters are mutually exclusive, right? That can lead to further confusion. Maybe throw an error on validation, or add some help text or additional organization to the filter area?
    3. The 'Reset' button doesn't clear Inline Block Type if a value has been set.
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024