Fatal error when using with ultimate cron

I don't think #8 is the correct solution. Other modules might add other exceptions, and so on. Instead I think we need to add a magical __call() method to our MasqueradeLogLogger class and forward the calls to the original logger:

public function __call(string $method, array $args) {
  if (is_callable([$this->originalService, $method]) {
    return call_user_func_array([$this->originalService, $method], $args);
  }
}

The patch works, I think. I ran cron while masquerading and it worked.

Coding standards tests is failing because the docs var names are not matching the ones from method:

+  /**
+   * Implements the magic __call() method.
+   *
+   * Allows calling a method of the original logger service if needed.
+   *
+   * @param string $name
+   *   The method name.
+   * @param array $arguments
+   *   The arguments of the method call.
+   *
+   * @return mixed
+   *   The method's return value, if any.
+   *
+   * @see https://www.drupal.org/project/masquerade_log/issues/3269608
+   */

We only need to inherit docs:

  /**
   * {@inheritdoc}
   */

Also, could you confirm that works with Ultimate Cron?

Yes, I am using Ultimate Cron.

Thank you. But still a last thought

+   *
+   * @see https://www.drupal.org/project/masquerade_log/issues/3269608

We should remove this. According to https://www.drupal.org/docs/develop/standards/php/api-documentation-and-... →

(...) This must be the only line in the docblock.

Also, I think it's a mistake (my bad!) to check for the existence and the "callability" of the method. We should just forward the call. The caller is responsible for calling a correct method, we should not not mess with that. Imagine that this module doesn't exist, what would be the error for calling a non-existing method? We should replicate that. So, I would suggest we replace:

+    if (is_callable([$this->originalService, $method])) {
+      return call_user_func_array([$this->originalService, $method], $args);
+    }

with just

    return $this->originalService->{$method}(...$args);

Commit ted, thank you! Will release a new minor.

I'm assuming that the latest patch has been tested with ultimate cron because I cannot test that.

Released in 8.x-1.2 →

Automatically closed - issue fixed for 2 weeks with no activity.