- First commit to issue fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
✨ Ability to configure additional languages (e.g. "bash" or "SQL") for CKEditor 5 CodeBlock plugin Fixed is now RTBC.
Once that lands, I'll create a new issue to add an automatic upgrade from this module to Drupal core's built-in
codeBlock
— including for the configuration of the enabled languages.Or actually … I think it might be better to do that in a new release of this module, because then this module can also point users to https://www.drupal.org/project/prism → per #8… 😊
Thoughts?
- 🇩🇪Germany Anybody Porta Westfalica
because then this module can also point users to https://www.drupal.org/project/prism → per #8… 😊
Which also isn't D10 compatible :D 📌 Automated Drupal 10 compatibility fixes Fixed
Which way would you suggest? I think your word has heavy weight (or however you'd say that in perfect English ;))
I like both ways, but depending of what's actually the "better" way if there's one. - Status changed to Needs review
over 1 year ago 3:32pm 27 April 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
✨ Ability to configure additional languages (e.g. "bash" or "SQL") for CKEditor 5 CodeBlock plugin Fixed has been committed to Drupal 10.1!
While https://www.drupal.org/project/prism → does not work on Drupal 10 yet, the following do:
- https://www.drupal.org/project/highlight_php → — with #3287893-4: Automated Drupal 10 compatibility fixes → applied:
- https://www.drupal.org/project/highlightjs_input_filter → — tested with version 1.0.1:
So I proposed a new approach in the issue summary:
- ✅ DONE: ✨ Ability to configure additional languages (e.g. "bash" or "SQL") for CKEditor 5 CodeBlock plugin Fixed
- Write update path.
- Update project page to point to https://www.drupal.org/project/highlight_php → and https://www.drupal.org/project/highlightjs_input_filter → to continue to have syntax highlighting.
- Mark this module as obsolete.
Thoughts? 😊
- 🇬🇧United Kingdom SirClickALot Somerset
Given that our use is almost 100% in creating educational 'coding' sites, we moved to Prism because it is offers easy support for line numbering code snippets which hightlight.js does not.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Core patch that adds an upgrade path from this module to Drupal core's
CodeBlock
, with the configured languages being preserved.Please review it over at 📌 Provide an upgrade path from "codesnippet" contrib CKEditor 4 plugin to "CodeBlock" core CKEditor 5 plugin Fixed .
- Status changed to Needs work
about 1 year ago 1:58pm 20 September 2023