- 🇬🇧United Kingdom very_random_man
Hi. I've noticed that this patch is actually causing an error if you have focal_point module installed without the migrate module. It looks like it ought to check if the module is enabled perhaps in the event subscriber.
PHP Fatal error: Uncaught Error: Class "Drupal\migrate\Event\MigrateEvents" not found in web/modules/contrib/focal_point/src/EventSubscriber/MigrationSubscriber.php:20
- Status changed to Needs review
over 1 year ago 10:52pm 18 August 2023 - 🇺🇸United States karlshea Minneapolis 🇺🇸
The focal_point_crop migration should have a Content tag instead of Configuration, since it relies on files having been imported.
I might have fixed the MigrateEvents not defined error but I don't know if it's the right way to do that or have even tested it.
- last update
over 1 year ago 158 pass, 1 fail - Status changed to RTBC
about 1 year ago 9:31am 26 September 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Confirmed again by @vistree at #3393712-3: Apply a newer focal_point migration patch to prevent error in some scenarios → 👍
- last update
11 months ago run-tests.sh fatal error - 🇲🇽Mexico ovilla
Thanks for the patch, I was trying to use the one in comment #31, but in my case I had a problem, because in my source site an image file is missing, then the migration was suddenly interrupted in the middle of the "focal_point_crop" migration, I received the following message:
Error: Call to a member function getFileUri() on null in Drupal\focal_point\Plugin\migrate\process\FocalPointToCropField->transform() (line 77 of /modules/contrib/focal_point/src/Plugin/migrate/process/FocalPointToCropField.php).
[warning] Drush command terminated abnormally.In case someone has the same problem, I attach a fix for skipping rows where no image file is found.
- 🇨🇦Canada leducdubleuet Chicoutimi QC
This is great, I can confirm the patch in comment #34 is working perfectly with the current release without any error and it migrates the focal points with success from Drupal 7!
It would be great to have it committed in a new release!
Thanks to all who worked on this patch!
- First commit to issue fork.
- last update
7 months ago run-tests.sh fatal error - 🇮🇳India rajeshreeputra Pune
Can we get the MR for ease of merge, Will merge and release this weekend. Thank you everyone working on this.
- last update
7 months ago run-tests.sh fatal error - last update
7 months ago 158 pass, 2 fail - last update
7 months ago 158 pass, 2 fail - last update
7 months ago 159 pass - last update
7 months ago 159 pass - last update
7 months ago 159 pass - Status changed to Fixed
7 months ago 3:46am 6 May 2024 -
Rajeshreeputra →
committed cbbfd431 on 2.x authored by
KarlShea →
Issue #3267350 by yash.rode, KarlShea, ovilla, huzooka, Rajeshreeputra,...
-
Rajeshreeputra →
committed cbbfd431 on 2.x authored by
KarlShea →
Automatically closed - issue fixed for 2 weeks with no activity.