[PHP 8.1] [Drupal 10] Upgrade grahl/ldap fork to follow symfony/ldap 5.4.x and require graph/ldap:^5.4

Created on 1 March 2022, over 2 years ago
Updated 20 March 2023, over 1 year ago

Problem/Motivation

Given that PHP 8.1 is now recommended for Drupal 9.4 and 10, I've begun testing sites with PHP 8.1. When loading a site with LDAP modules enabled, I got the following deprecation error:

Deprecated: Return type of Symfony\Component\Ldap\Adapter\ExtLdap\Collection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/grahl/ldap/Adapter/ExtLdap/Collection.php on line 48

Steps to reproduce

Run a site on PHP 8.1 and clear caches.

Proposed resolution

Updating grahl/ldap up to 5.4.8 would be the ideal solution. Adding the temporary attribute would be a quick fix for now.

πŸ› Bug report
Status

Closed: outdated

Version

4.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States micahw156

Live updates comments and jobs are added and updated live.
  • PHP 8.1

    The issue particularly affects sites running on PHP version 8.1.0 or later.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024