- miiimooo Europe
Tested this with a media entity (Media source: File, the file is stored in a simple File field type):
- The name/label of the merged entity got overwritten with the file name (my media entity type is configured with a field mapping Name -> Name; maybe that's causing this?)
- The label on the media "Merge translations" form says "Remove term" instead of "Remove media"
- Loading the merge form I get
reset(): Calling reset() on an object is deprecated in Drupal\merge_translations\Form\MergeTranslationsForm->__construct() (line 113 of /app/web/modules/contrib/merge_translations/src/Form/MergeTranslationsForm.php).:"
- Status changed to Needs review
about 1 year ago 10:50am 20 November 2023 - 🇨🇴Colombia sebasgd
I've tested this patch and it seems to work. I only found minor thing and is that when you try to merge media, the option to remove the source item says "Remove term" instead of "Remove media".
- Status changed to Needs work
5 months ago 2:13pm 7 August 2024 - 🇫🇮Finland sokru
Otherwise looks good, but the issue reported by @sebasgd on #14 needs to be resolved.
Maybe increasing the test coverage for this wouldn't hurt, for that I'd recommend merging 📌 Set up Gitlab CI Fixed first. - 🇵🇱Poland lamp5 Rzeszow
📌 Set up Gitlab CI Fixed merged, If you have a free time, you can go ahead with this task.
- Status changed to Needs review
5 months ago 2:42pm 11 August 2024 - 🇫🇮Finland sokru
Resolved the issue mentioned on #14 by changing the option to more generic.
I also refactored the tests to include test for actual merging.
Leaving up to maintainers if they wish tests also for media entities. IMHO it feels a bit of repetition (and maintenance burden) to include also tests for media entities. - 🇺🇸United States banoodle San Francisco, CA
Patch #5 no longer applies on the latest 2.0.x-dev branch.
Attaching re-rolled patch.
Thanks!
- miiimooo Europe
If you need to patch 2.0.0 here is the old patch that still applies correctly