Contrib.social

Remove use of final Guzzle client class

Open on Drupal.org →
Created on 13 February 2022, almost 3 years ago
Updated 24 February 2023, over 1 year ago

Problem/Motivation

The advisory_feed_test module extends and decorates the guzzle client to rewrite the request url during testing. This is a problem though because the guzzle client is marked @final so could break including possibly and actually fatal error if future versions are really final.

PHPStan correctly marks this as a problem so its in our baseline for level 0 fixes.

Steps to reproduce

This is an interaction with an annotation so it isn't causing errors but it does fix an entry in the phpstan baseline.

Proposed resolution

Replace the extended class with Middleware that can accomplish the same result.

🐛 Bug report
Status

Fixed

Version

10.0 ✨

Component
System  →

Last updated 7 days ago

No maintainer
Created by

🇺🇸United States neclimdul Houston, TX

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024