View any unpublished commerce_product

Tested this in our environment and helps us a bunch. Still works for commerce 2.35. Thank you!

Would have been nice to have this handled by the Entity module. Unfortunately, ✨ Add: "View any unpublished [entity_type]" permission Needs work never landed.

The code needs work to make it more readable and reduce cognitive load. Also, the logic is redundant. Why add an OR condition for a boolean field when allowing both states?

ProductQueryAccessHandler within the current MR contains lot of code copied from its base class. I think we should avoid that redundancy and simplify the patch.

I don't want to change the existing MR, so I created a patch.

Even if all tests pass, the commerce_products view breaks using the patch in #16. It just displays unpublished products.
I think I fixed that now.

In general in would be better to solve ✨ Add: "View any unpublished [entity_type]" permission Needs work , but we need this feature quickly, so we use this patch here.

We just ran into the same issue, this permission is definitely still missing. Anyway I agree with #17 - thanks for the patch @mkalkbrenner!!

So I'll set this RTBC for the maintainer to decide if this should be postponed or integrated already.

Since we're depending on the entity module, I also think it makes more sense to add support for the "view any unpublished [entity_type] permission" there to avoid duplicating the logic in Commerce.

Thanks! Postponed on ✨ Add: "View any unpublished [entity_type]" permission Needs work

Even if the Entity API fix lands, we'll still need to update Commerce, so we need to keep this opened :). But I guess "postponed" is an okay status.