- 🇳🇱Netherlands arantxio Dordrecht
Tested this in our environment and helps us a bunch. Still works for commerce 2.35. Thank you!
- 🇮🇱Israel jsacksick
Would have been nice to have this handled by the Entity module. Unfortunately, ✨ Add: "View any unpublished [entity_type]" permission Needs review never landed.
- First commit to issue fork.
55:20 54:21 Running- Status changed to Needs work
over 1 year ago 4:23pm 23 May 2023 - 🇺🇸United States mglaman WI, USA
The code needs work to make it more readable and reduce cognitive load. Also, the logic is redundant. Why add an
ORcondition for a boolean field when allowing both states? 25:17 24:21 Running- Status changed to Needs review
over 1 year ago 1:14pm 20 June 2023 - last update
over 1 year ago 777 pass, 2 fail - 🇩🇪Germany mkalkbrenner 🇩🇪
ProductQueryAccessHandler within the current MR contains lot of code copied from its base class. I think we should avoid that redundancy and simplify the patch.
I don't want to change the existing MR, so I created a patch.
- last update
over 1 year ago 786 pass - last update
over 1 year ago 786 pass - 🇩🇪Germany mkalkbrenner 🇩🇪
Even if all tests pass, the commerce_products view breaks using the patch in #16. It just displays unpublished products.
I think I fixed that now.In general in would be better to solve ✨ Add: "View any unpublished [entity_type]" permission Needs review , but we need this feature quickly, so we use this patch here.
