Minimum number of revisions to keep and content moderation

Created on 7 February 2022, over 2 years ago
Updated 7 March 2024, 4 months ago

Problem/Motivation

What does mean miminum in "Minimum number of revisions to keep" and what is the precise behaviour ?
Should it not be "number of revisions to keep" ?
In case of usage of content moderation , the "number of revisions to keep" is not realised after cron

Steps to reproduce

- Having a content type with different moderation state from content moderation.
-Set "Minimum number of revisions to keep" to 5
- Run revision delete

the revisions that are more recents than the actual revision are not deleted as they should .

Proposed resolution

- If this is a normal behaviour, it should be precised on the module interface when using content moderation on the site

πŸ’¬ Support request
Status

Closed: outdated

Component

Code

Created by

πŸ‡«πŸ‡·France matoeil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡±Netherlands seanB Netherlands

    We just added a 2.x version of the module. This is a complete rewrite based on plugins to determine which revisions can be deleted. It also uses a queue worker to actually delete revisions. In this case "minimum" means that the "amount" plugin guarantees that at least an x amount of revisions are always kept. Other plugins (like delete revisions after X amount of time) can also have an opinion, which means that it is possible that more revisions are kept.

    For example, if you want to keep revisions for a minimum of 6 months and also want to keep at least 5 revisions, you always keep all revisions created in the last 6 months. Even if they exceed the minimum of 5 revisions. On the other hand, if you only created 2 revisions in the last 6 months, we still keep older revisions with a maximum of 5.

    Hope this helps a bit.

  • πŸ‡­πŸ‡ΊHungary Grabby

    I appreciate the hard work going into the rewrite. That said, it seems to me that a module concerned with deleting revisions would be at least as concerned with the maximum retained as with the minimum. For my part I use the module to keep revisions to the bare minimum possible since I don’t need them on some projects. Not sure if this amounts to a feature request and, if so, whether it should be a separate issue, but I would really like to be able to specify the MAXIMUM number of revisions to keep, with as few as one possible. Thanks again for all the effort!

  • πŸ‡³πŸ‡±Netherlands seanB Netherlands

    The plugins shipped with the 2.x version of the module can each be configured, enabled / disabled however you like. If you only configure the number of revisions to keep (for example, a minimum of 2), all other revisions will be deleted (since other plugins won't have an opinion). In that case, the minimum will also be the maximum number of allowed revisions. The reason we can't call it a "maximum", is because theoretically other plugins might also have an opinion.

    Hope this helps!

  • Status changed to Closed: outdated 4 months ago
  • πŸ‡¨πŸ‡¦Canada adriancid Montreal, Canada

    Closing because the current development is being made in branch 2.x

Production build 0.69.0 2024