Settings form has notice when role_mapping is empty

Open on Drupal.org →

Created on 27 January 2022, about 3 years ago

Updated 26 September 2023, over 1 year ago

Problem/Motivation

The settings form renders a 'notice' when no role_mapping is available.

Steps to reproduce

Install default module without any settings saved. Then load the settings form.

Proposed resolution

Make sure the code can handle empty role mappings.

foreach ($roles as $role_id => $role) {
      $default = '';
      if (is_array($role_mappings[$role_id])) {

Change the is_array check to $role_mappings itself to prevent this notice:

Error message
Close
Notice: Trying to access array offset on value of type null in Drupal\openid_connect\Form\OpenIDConnectSettingsForm->buildForm() (line 199 of modules/contrib/openid_connect/src/Form/OpenIDConnectSettingsForm.php).
Drupal\openid_connect\Form\OpenIDConnectSettingsForm->buildForm(Array, Object)

🐛 Bug report

Status

Closed: duplicate

Version

2.0

Component

Code

Created by

🇳🇱Netherlands Krilo_89

Live updates comments and jobs are added and updated live.