Reduce system.name to 128 chars

Created on 25 October 2008, over 15 years ago
Updated 5 May 2023, about 1 year ago

Problem/Motivation

During our work with chx on #298600: DBTNG: make module_implements work regardless of bootstrap phase β†’ , we stumbled over an issue regarding the length of module, function and hook names.

In a nutshell: currently module names are limited to 255 chars (the length of system.name), but function names are limited to 255 chars. That means that hook names are limited to... -1 chars (because strlen(module_name . '_' . hook_name) <= 255...).

Proposed resolution

So I suggest we settle on:

- modules names limited to 128 chars
- function names limited to 255 chars
- hook names limited to 126 chars

That would mean changing system.name to 128 chars (ie. themes will also be affected, but I don't think this would have any consequences), so also system.owner, and may be some other columns using those.

Remaining tasks

This needs to still be decided upon.

User interface changes

None.

API changes

The naming system would be changed.

Data model changes

None.

πŸ“Œ Task
Status

Closed: outdated

Version

9.5

Component
SystemΒ  β†’

Last updated 1 day ago

No maintainer
Created by

πŸ‡«πŸ‡·France Damien Tournoud

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Closing as outdated as there has not been movement or a follow up in 7 years. If still a valid task please reopen with an updated issue summary.

Production build 0.69.0 2024