The styling of "NULL"/"TRUE"/"FALSE" and "null"/"true"/"false" is inconsistent:
This leads to silly things. For example... If I copy a symbol from a valid docblock (eg "false") and paste it into code, then the linter rejects the symbol (preferring "FALSE"). The same problem happens in reverse (copying symbols from code to a docblock).
What's the point of docblocks if they can't document the actual symbols expected in the code?
The following code is internally consistent - but it's rejected because of "Drupal.Commenting.FunctionComment.IncorrectParamVarName":
/**
* Snafu.
*
* @param string|NULL $a
* Some kind of parameter.
*/
function snafu($a) {
if ($a === NULL) {
echo 'Your style guide is consistent.';
}
}
The following code is internally consistent - but it's rejected because of "Generic.PHP.UpperCaseConstant.Found":
/**
* Snafu.
*
* @param string|null $a
* Some kind of parameter.
*/
function snafu($a) {
if ($a === null) {
echo 'Your style guide is consistent.';
}
}
The following code is accepted by the linter as valid style - but it is internally inconsistent. Symbols in code and documentation cannot match.
/**
* Snafu.
*
* @param string|null $a
* Some kind of parameter.
*/
function snafu($a) {
if ($a === NULL) {
echo 'Your style guide is inconsistent.';
}
}
Either:
Either:
n/a
n/a
n/a
Active
Coding Standards
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
For PHP, null is not a reserved word. It is a type, but it should not be confused with NULL, which is a constant whose type is null.
Closing as a duplicate of ✨ Stop using uppercase TRUE, FALSE, NULL literals Active and moved credit