\Drupal\Core\TypedData\ComplexDataDefinitionBase::$propertyDefinitions defaults to null, but is expected to be an array. We can do this in the property declaration and clean up checks which check to see if the value is set or not.
Dump a MapDataDefinition to an array and propertyDefinitions is null when you expect an array
/**
* An array of data definitions.
*
* @var \Drupal\Core\TypedData\DataDefinitionInterface[]
*/
protected $propertyDefinitions = [];
Remove checks for isset since the value is always an array – empty or not.
Needs work
10.1 ✨
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I'm not sure how we could test this specifically.
Dump a MapDataDefinition to an array and propertyDefinitions is null when you expect an array
I need to see where/how I did this, but seems like a simple unit test.
Moving to NW for the test in #8,
If not possible though I can re-review also as is.