Fix bootstrap_layouts_theme_registry_alter() prevents subclassing BootstrapLayoutsBase

Created on 16 December 2021, almost 3 years ago

Updated 2 February 2023, almost 2 years ago

Problem/Motivation

If you attempt to subclass BootstrapLayoutsBase and swap it out in hook_layout_alter(), then _bootstrap_layouts_preprocess_layout() is not registered as a theme registry entry.

Steps to reproduce

Proposed resolution

Fix the check in bootstrap_layouts_theme_registry_alter()

Remaining tasks

Tests

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report

Status

Fixed

Version

5.0

Component

Code

Created by

🇺🇸United States tim.plunkett Philadelphia

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇯🇴Jordan Rajab Natshah Jordan
Rajab Natshah → made their first commit to this issue’s fork.
Comment almost 2 years ago →
System Message

Rajab Natshah → committed 2e087032 on 8.x-5.x authored by tim.plunkett →
Issue #3254835: bootstrap_layouts_theme_registry_alter() prevents...
Status changed to Fixed almost 2 years ago8:55am 31 January 2023
Comment almost 2 years ago →
🇯🇴Jordan Rajab Natshah Jordan
Merged ... Thank you
Comment almost 2 years ago →
🇯🇴Jordan Rajab Natshah Jordan
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024