WebP is not compatible with S3FS module

Tested on Drupal 10.2.6 / S3FS 8.x-3.4 / WebP 8.x-1.0-rc2 with responsive image style and I can confirm that patch #7 works with this configuration and Webp images are correctly created in the bucket.

Curious, we also ran into this issue but did not install the WebP module (so the patch didn't work because there was nothing to patch). Does it make sense for us to install webp and then the patch for WebP to work with Drupal 9?

The patch at #7 doesn't do what the proposed patch does right now -- the code block is currently in a place where it can't ever execute, from what I can tell.

Current patch

    foreach (['system.private_file_download', 'system.files'] as $route_id) {
      if ($route = $collection->get($route_id)) {
        $route->setDefault('_controller', 'Drupal\webp\Controller\FileDownloadController::download');
      }
      if ($route = $collection->get('s3fs.image_styles')) {
        $route->setDefault('_controller', 'Drupal\webp\Controller\ImageStyleDownloadController::deliver');
      }
    }

So that would only happen if the route was both 'system.private_file_download' (for example) AND 's3fs.image_styles', which doesn't make any sense.

I wonder if some update changed line numbers or something? Otherwise I don't know how this could be working for anyone.

I'm adding a new patch that moves the new lines out of that if statement like this:

    foreach (['system.private_file_download', 'system.files'] as $route_id) {
      if ($route = $collection->get($route_id)) {
        $route->setDefault('_controller', 'Drupal\webp\Controller\FileDownloadController::download');
      }
    }
    if ($route = $collection->get('s3fs.image_styles')) {
      $route->setDefault('_controller', 'Drupal\webp\Controller\ImageStyleDownloadController::deliver');
    }