Store the successful authentication plugin's ID on the request

Created on 11 December 2021, over 2 years ago
Updated 18 February 2023, over 1 year ago

Problem/Motivation

Issues such as ✨ [PP-1] Disable CSRF token check for non-CSRF vulnerable authentication providers Needs work require the AuthenticationManager provide some way for other services to determine which authentication plugin "won" in authenticating the current request. Various other parts of the routing and even image derivative generation systems use the request's attributes ParameterBag for storing computed data about the request. Let's do the same here.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

✨ Feature request
Status

Needs work

Version

10.1 ✨

Component
Request processingΒ  β†’

Last updated about 10 hours ago

No maintainer
Created by

πŸ‡ΊπŸ‡ΈUnited States bradjones1 Digital Nomad Life

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β†’ as a guide.

    Seems like a feature request but if you disagree let me know.

    Seems like this could use a simple test coverage showing the existence of the plugin ID

Production build 0.69.0 2024