- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Not sure I see the "why" this should be done.
Could you elaborate more - Status changed to Needs review
almost 2 years ago 9:50pm 8 February 2023 - 🇭🇺Hungary Sweetchuck Budapest
- What is the purpose of the test coverage report?
- It is intended to help identify areas of the system that have not been adequately tested, and to provide guidance on which tests should be conducted next.Not everything has to be covered with Unit or Kernel tests.
Maybe a certain part of the code is covered with FunctionalJavascript test, but for that is very difficult to get coverage report.
It is also true if a file is 100% green, it doesn't mean that it is covered with right and meaningful tests.Do we need to write test to cover the functions in any *.api.php files?
Can we write test to cover the functions in any *.api.php files?If the answer is "no", then why are those files in the coverage report?
- Status changed to Needs work
almost 2 years ago 3:07pm 9 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- @sweetchuck opened merge request.
- Status changed to Needs review
almost 2 years ago 7:36pm 9 February 2023 - Status changed to RTBC
almost 2 years ago 4:58pm 11 February 2023 - 🇺🇸United States smustgrave
Thank you for the explanation. Will see what the committers think.
- Status changed to Fixed
almost 2 years ago 12:21pm 17 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.