We noticed that on some page loads, when forms rendered are in a block on a node page, the forms don't submit on the first try and simply result in the reload of the page. On closer inspection of the site, we noticed that the node id didn't correspond with the form id.
For example, when loading /node/1059, the form's id was webform_submission_questions_node_994_add_form. Once the form was submitted the first time, the page reloaded (not submitting the form) and re-rendered the form with the correct form id webform_submission_questions_node_1059_add_form.
Load a page with a block having a webform, then load another page, containing the webform block, and verify the form ids of the block forms.
Add caching dependency on the source entity if one exists.
Review changes.
None.
None, beyond fixing cache-ability of the page.
None.
Needs work
6.1
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I think we have two similar solutions to the same problem.
I am open to merging this if we feel the change is safe and won't cause regressions