Update composer constraint for h5p for PHP 8 compatibilty

Created on 30 November 2021, over 2 years ago

Updated 9 February 2024, 5 months ago

Currently module code is fully compatible with PHP8

One of the dependencies used by module h5p/h5p-editor doesn't have few things compatible with PHP 8

For package h5p/h5p-editor, there has been a PR and it has been merged to master branch https://github.com/h5p/h5p-editor-php-library/pull/128
However, there hasn't been a new release of the package.

I think we should to apply the patch h5p/h5p-editor in composer.json so it is compatible with PHP 8

Add a patch in composer.

Patch on the way!!

🐛 Bug report

Status

Closed: duplicate

Version

2.0

Component

Code

Created by

🇮🇳India mohit_aghera Rajkot

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 12 months ago →
🇺🇸United States SocialNicheGuru
The MR seems much bigger than the patch applied to the h5p/h5p-editor repo
Comment 8 months ago →
🇬🇧United Kingdom catch
The copies of the libraries shipped with the module should be removed entirely in 🐛 H5P libraries included twice Needs work

However we should also update the composer constraint to update the version in vendor to the newest.
Status changed to Closed: duplicate 5 months ago10:44pm 9 February 2024
Comment 5 months ago →
🇨🇦Canada ShaunDychko
The latest 2.0.x already support PHP 8. The issue of removing libraries is a duplicate of 📌 Remove vendor directory and composer.lock from project repository Active .

Production build 0.69.0 2024