Contrib.social

Twig debug mode causes parse error in appendXML

Open on Drupal.org →
Created on 29 November 2021, over 2 years ago
Updated 1 May 2024, about 2 months ago

Problem/Motivation

If Twig Debug mode is true in services.yml, glossify fails with the following error:

Warning: DOMDocumentFragment::appendXML(): Entity: line 4: parser error : Double hyphen within comment: in Drupal\glossify\GlossifyBase->parseTooltipMatch() (line 144 of modules/contrib/glossify/src/GlossifyBase.php).

This is due to the

<!-- TWIG DEBUG -->

comments added to the rendered abbreviation.

Steps to reproduce

  1. Set twig debug mode = true in services.yml
  2. Load a page with glossary content
  3. Notice the error

Proposed resolution

Strip comments from rendered glossary output.

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇺🇸United States draenen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 months ago →
    🇺🇸United States chkitchens

    Just ran face first into this same issue on version 3.0.

  • Comment about 2 months ago →
    🇺🇸United States chkitchens

    Applied patch and confirmed that it still works against version 3.0. I know this ticket was originally made against v2.0. Is there a way we could fork this fix against the 3.0 branch that doesn't involve making a duplicate issue ticket?

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024