- πΊπΈUnited States drumm NY, US
The field has been disabled for awhile. We should audit the codebase to remove all references to
taxonomy_vocabulary_52
, including deleting the field, ahead of upgrading Drupal.org past Drupal 7. π Organization page: Remove Offices in field Active has an example of this replacement for the community case studies filter. - πͺπΈSpain fjgarlin
From slack: https://drupal.slack.com/archives/C5ABFBZ5Z/p1679860381481319
@dasjo:
i have filtered for switzerland: https://www.drupal.org/case-studies/community?country%5B%5D=24422 β
it seems like most displayed case studies aren't related to switzerland
it might be that it filters by organizations serving a location, if so it might be more appropriate to only filter by organizations having an office in a certain location
e.g. https://www.drupal.org/case-study/schwaketenbad-website-relaunch β is a case study by 1xinternet that has offices in germany, spain and iceland.
the issue where it was requested and implemented can be found here https://www.drupal.org/project/drupalorg/issues/3207977 βreply @fjgarlin:
the feature has Locations served: https://git.drupalcode.org/project/drupalorg/-/blob/7.x-3.x/features/dru..., which actually explains why these results are showing up.
the change happened in this commit https://git.drupalcode.org/project/drupalorg/-/commit/36d4ce02e6a145c0ea... and seems to be a part of a larger issue where that old field is being deprecated: π Organization page: Remove Offices in field Activeso maybe itβs using the wrong field.
* Before: taxonomy_vocabulary_52
* Current: field_organization_loc_served
* Expected: field_office_location??? - πΊπΈUnited States drumm NY, US
The new address field on organizations, βOffice locationsβ (
field_office_locations
) does have a country-of-address filter, so that is an option for case studies, and anything else that needs replacing. - @fjgarlin opened merge request.
- Status changed to Needs review
about 2 years ago 2:34pm 28 March 2023 - πͺπΈSpain fjgarlin
Note that the data on my copy is old so new case studies might not show, but I've done the changes on the field for that view. I've changed from "Locations served" to "Office locations".
You can see the page here: https://fjgarlin-drupal.dev.devdrupal.org/case-studies/community?country...
And the MR with the changes here: https://git.drupalcode.org/project/drupalorg/-/merge_requests/159/diffs
-
drumm β
committed 4a5c1ce7 on 7.x-3.x authored by
fjgarlin β
Issue #3249687: Use offices in country instead of locations served for...
-
drumm β
committed 4a5c1ce7 on 7.x-3.x authored by
fjgarlin β
- Status changed to Active
about 2 years ago 5:58pm 28 March 2023 - πΊπΈUnited States drumm NY, US
Looks good, going ahead and deploying this shortly. Resetting to active since there is more work to do in this issue.
-
drumm β
committed 4a5c1ce7 on reg-prot authored by
fjgarlin β
Issue #3249687: Use offices in country instead of locations served for...
-
drumm β
committed 4a5c1ce7 on reg-prot authored by
fjgarlin β