- 🇺🇦Ukraine andriy khomych
Hey @kimpepper, @cryt1c
Thank you for work on this feature. It looks promising, any news or updates?
It can be useful to merge it. - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - 🇺🇦Ukraine andriy khomych
@kimpepper, I have to open another fork - https://git.drupalcode.org/project/feeds/-/merge_requests/144
due to access limitations. As well, can I request to be a maintainer on this module? I'm using it on some projects. - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - @andriy-khomych opened merge request.
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - @andriy-khomych opened merge request.
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - @andriy-khomych opened merge request.
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - @andriy-khomych opened merge request.
- 🇺🇦Ukraine andriy khomych
I have "You have push access.". Full commands list:
dd & fetch this issue fork’s repository git remote add feeds-3249252 git@git.drupal.org:issue/feeds-3249252.git git fetch feeds-3249252 Copy to clipboard Or, if you do not have SSH keys set up on git.drupalcode.org: Add & fetch this issue fork’s repository git remote add feeds-3249252 https://git.drupalcode.org/issue/feeds-3249252.git git fetch feeds-3249252 Copy to clipboard feeds_ftp_fetcher-3249252-2.x Comparechanges, plain diff MR !144 merge error Check out this branch git checkout -b 'feeds_ftp_fetcher-3249252-2.x' --track feeds-3249252/'feeds_ftp_fetcher-3249252-2.x' Copy to clipboard PHP 7.4 & MySQL 5.7, D9.5.5 Not currently mergeable. Can not add test, MR is not mergeable 3249252-contribute-ftp-fetcher Comparecompare Check out this branch git checkout -b '3249252-contribute-ftp-fetcher' --track feeds-3249252/'3249252-contribute-ftp-fetcher' Copy to clipboard 2 hidden branches Create new branch Or push your current local branch from your Git clone git push --set-upstream feeds-3249252 HEAD
However, it creates an every time new branch from https://git.drupalcode.org/project/feeds and adds its history:
https://git.drupalcode.org/project/feeds/-/merge_requests/145 git@git.drupal.org:issue/feeds-3249252.git
https://git.drupalcode.org/project/feeds/-/merge_requests/144 git@git.drupal.org:issue/feeds-3249252.gitThis is part problem, and I guess feeds maintainer can move it to the correct base repo. The easiest solution I see is to use this fork and push changes here :
https://git.drupalcode.org/project/feeds_ftp_fetcher/-/merge_requests/1 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
kim.pepper → made their first commit to this issue’s fork.
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. -
kim.pepper →
committed 25365dc2 on 2.x authored by
Cryt1c →
Issue #3249252 by Cryt1c, Andriy Khomych: Contribute FTP Fetcher Plugin
-
kim.pepper →
committed 25365dc2 on 2.x authored by
Cryt1c →
- Status changed to Fixed
about 1 year ago 12:12am 20 November 2023 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Committed to the 2.x branch. Thanks!
I will add a follow-up issue to fix some of the other outstanding issues.
Automatically closed - issue fixed for 2 weeks with no activity.