Search plugin 'node_search' should use query builder instead of direct SQL queries for total and remains

Created on 9 November 2021, almost 3 years ago

Updated 17 March 2023, over 1 year ago

I think queries for counting total and remaining nodes to index should be built using query builder instead of direct SQL queries.

Take a look at `\Drupal\node\Plugin\Search\NodeSearch::indexStatus`

Fetch results using dynamic query builder.

📌 Task

Status

Closed: works as designed

Version

10.1 ✨

Component

Node system →

Last updated 1 minute ago

No maintainer

Created by

🇷🇺Russia Niklan Russia, Perm

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States smustgrave
triggering for 10.1
Status changed to RTBC over 1 year ago7:58pm 7 February 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Seems like a valid cleanup. Lets see what the committers think!
Status changed to Closed: works as designed over 1 year ago2:48pm 17 March 2023
Comment over 1 year ago →
🇬🇧United Kingdom catch
There's nothing dynamic in these queries, so they are fine using direct, I think this is 'by design'.

Production build 0.71.5 2024