- 🇧🇪Belgium beerendlauwers
Changing the "Alert Type" dropdown to become the bundle type seems like a great way to migrate existing alerts and align the structure of this module to Drupal's entity type architecture.
Just getting up to speed on this module and interested in a few open issues:
-
#3243392: Allow Sitewide Alerts to be Fieldable →
(mine)
-
#3229142: Add ability to put alerts in blocks →
and i started thinking about the idea of "alert types". Consider this:
I would suggest splitting existing/new functionality across bundle/entity as:
Bundle/Type:
- option to use default placement at top of page or create a block for that Type
- define page visibility per type - this gives you the ability to define a type to be placed in a certain location on certain pages - technically the page visibility isnt required any more as block setting can handle that
- this way visibility doesnt have to be redefined each time an alert is added - it is simply an alert of Type X
Entity/Alerts:
- still off scheduling and style (type would be a better word than style; but i admit that will get confusing once bundles are added).
I havent yet stumbled upon how to make alert entities fieldable without providing bundles (as is done with User entity); but i do know how to do this if we add ability to add bundles - so that solves my fieldable issue as well. :)
Just some thoughts. The fieldable addition i need for sure but assuming that can be done without adding bundles (at least with a fixed single bundle). But if we also need "site section" alerts on top of site wide alerts.. then this will mean different placement and therefore blocks - and then i think a very good reason to have alert types. I can do the code for all of this if maintainer is interested in this feature enhancement.
Postponed: needs info
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Changing the "Alert Type" dropdown to become the bundle type seems like a great way to migrate existing alerts and align the structure of this module to Drupal's entity type architecture.