Public files deployment naming strategy should be required, leads to fatal error in PHP 8

Created on 1 October 2021, over 2 years ago
Updated 21 February 2023, over 1 year ago

Problem/Motivation

If you leave the Naming convention blank and try to build a preview site you'll get a fatal error in php 8. This is because \Drupal\preview_site\Plugin\PreviewSite\Deploy\PublicFiles::getDeploymentBaseUri tries to call trim() with null as the first argument.

Steps to reproduce

  • Create a public files deploy strategy with no naming convention
  • Create a preview
  • Build and deploy

Proposed resolution

Make the naming strategy mandatory.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024