Shepherd JS not IE11 compatible

Created on 30 September 2021, over 3 years ago

Updated 23 July 2023, over 1 year ago

Problem/Motivation

In #3051766: Deprecate and replace jQuery Joyride (for tours) → , the Tour module stopped using Jquery Joyride in favor of ShepherdJS. So as of Drupal 9.2, Tours don't work in IE11. I haven't seen this reported anywhere, so it's possible nobody has run into this due to both IE11 and Tour not being the most heavily used browser/module these days.

The current ShepherdJS uses a bunch of arrow function syntax, so it's not something that can be easily polyfilled. I did confirm that if I run core's ShepherdJS through the transpiler used for our .es6.js files, it will work with IE11.

When #3051766: Deprecate and replace jQuery Joyride (for tours) → was first opened, ShepherdJS was IE11 compatible, so there's at least some semblance of explanation as to how we missed this.

Steps to reproduce

Proposed resolution

Some options:

Running Shepherd through Core's transpiler fixes the issue, so perhaps some version of that could work, provided it doesn't introduce policy headaches.

It may also be possible to leverage the fact that IE11 is not supported in Drupal 10. If there was logic that used the legacy joyride tours only when a browser is detected as IE11, maybe this could be done without violating the deprecation policy as it's in a browser that won't support Drupal 10 at all and as a result does not need deprecation warnings about one small component of Drupal.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Closed: won't fix

Version

11.0 🔥

Component

Tour →

Last updated 6 days ago

Maintained by
🇦🇺Australia @nick_schuch

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.

JavaScript

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇳🇿New Zealand quietone
This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Tour module Fixed . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Tour Postponed .

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.
Status changed to Closed: won't fix over 1 year ago12:06pm 23 July 2023
Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
To be practical, we are extremely unlikely to fix this now. IE11 is end of life and only supported in Drupal 9; we are only fixing critical security issues in Drupal 9 until it reaches end of life in November, and this is not a security issue. Therefore, closing this as won't fix.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024