Contrib.social

Commerce checkout pane forgot password link always uses username even when disabled

Open on Drupal.org →
Created on 24 September 2021, almost 3 years ago
Updated 12 October 2023, 9 months ago

Problem/Motivation

The forgot password link that displays during Commerce checkout when a password is invalid uses the account's name in the query string even if the login by username is disabled.

Steps to reproduce

Enable checkout pane in commerce, set the login by username config to false.
Try logging in during checkout with known user and incorrect password, click the link to forgot password - notice the username prefilled.

Proposed resolution

Attached patch.

🐛 Bug report
Status

Postponed: needs info

Version

1.0

Component

Code

Created by

🇺🇸United States nsciacca Connecticut

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 11 months ago →
    🇩🇪Germany Anybody Porta Westfalica

    Thank you very much for the patch @nsciacca - could you perhaps provide it as MR and add a test for this, so we can be sure it's fixed now and in the future?

  • Status changed to Postponed: needs info 9 months ago
  • Comment 9 months ago →
    🇩🇪Germany Grevil

    Can not reproduce this Problem any more.

    Steps to reproduce

    Go to the commerce checkout and login with incorrect password:

    Both "Forgot password?" links will redirect to the normal reset your password page:

    Where no username is prefilled.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024