Integrate with ECA

@Berdir regarding your comment in #36 it looks like Flag and ECA are now working together nicely. The only missing piece in the flag module to make the collaboration of the two meaningful is the token support, which is addressed in 🐛 Re-implement hook_tokens() Needs work . With the latest patch from there it looks as if things are OK and this one could be closed.

ECA Flag integration Beta-1 is now available: https://www.drupal.org/project/eca_flag →

jurgenhaas, what the status of this issue? Is it relevant?

The integration between ECA and flag is being done in the separate eca_flag module and working nice. But the fix in MR!29 should still be added to the flag module, as it fixes the action plugin in this module which uses a config value that's not always been set and therefore raises a warning. It's an easy fix, so I think it can be merged with any risk.

Note that if you're just using a flag as a UI to trigger the ECA action and you don't care about the flagging entity that doing that creates, you'd be better off using https://www.drupal.org/project/action_link → instead.

But the fix in MR!29 should still be added to the flag module, as it fixes the action plugin in this module

Maybe I'm wrong as this is long time ago. But since #3322747: Action plugins cannot be instantiated in a generic way → is in for a while now, which is supposed to have the problem fixed already, I don't think MR29 is necessary anymore.

Note that if you're just using a flag as a UI to trigger the ECA action and you don't care about the flagging entity that doing that creates, you'd be better off using https://www.drupal.org/project/action_link → instead.

Interesting module. Just a side note, ECA already has anything included to achieve the same thing, e.g. using "Render custom form" with a submit button and adding an Ajax handler to it. Or create a regular link with "Render: link" and build an ECA endpoint for it.

Thanks all, MR29 committed!

I explored the same issue ✨ VBO support Needs review .

@jurgenhaas how do you think, do that change help you with ECA?

https://git.drupalcode.org/project/flag/-/merge_requests/31/diffs

Now, I reverted this issue commit

@ivnish as @mxh wrote in #43, this MR is no longer required since #3322747: Action plugins cannot be instantiated in a generic way → fixed the issue already in a different way. Closing as duplicate.