- First commit to issue fork.
- Assigned to seda12
- Status changed to Needs work
over 1 year ago 9:44am 28 July 2023 - 🇫🇷France Grimreaper France 🇫🇷
Per #3353493-12: Add ui_styles_page sub module → . On the long term ui_styles_layout_builder will go into:
- ui_styles_block for the block part
- ui_styles_layout for the layout part (section and regions) - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @grimreaper opened merge request.
- Assigned to Grimreaper
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - Assigned to pdureau
- Status changed to Postponed: needs info
over 1 year ago 4:41pm 4 August 2023 - 🇫🇷France Grimreaper France 🇫🇷
Problem: there is currently nothing to alter all layout plugins automatically. This problematic is common for all plugins implementing PluginFormInterface.
I found out 📌 Introduce hook_plugin_subform_alter() for use with PluginFormInterface Needs work , which seems to be exactly what is needed to alter the configuration form automatically anywhere the plugin is used.
I think, this would be useful for ui_styles_block too, to avoid using a hook_form_alter, and so be generic between block layout and Layout Builder.
So we can either:
- wait for the Core issue to be merged, then implement a generic solution.
- delay ui_styles_layout creation (and ui_styles_layout_builder_deprecations) and manage the regions inside ui_styles_layout_builder for the moment.I also imagined a solution to alter layout plugins which use the LayoutOptions class form the Layout Options module, by providing a layout class which extends Layout Options class, but not generic at all.
- Assigned to Grimreaper
- Status changed to Active
over 1 year ago 7:40am 7 August 2023 - 🇫🇷France Grimreaper France 🇫🇷
After discussion with @pdureau, 2 days ago.
Ok to currently do it in ui_styles_layout_builder until Core provides a generic alteration mechanism.
- 🇫🇷France Grimreaper France 🇫🇷
I wonder if on the long term it would not be better to provide a new LayoutOptions plugin for the styles.
But as we may have also discussed to go full UI Patterns even for layouts, then it should be a UI Patterns Settings plugin...
So currently sticking to the same logic of only adding parts in the form.
- 🇫🇷France Grimreaper France 🇫🇷
I tried to use hook_preprocess_layout but the problem is that in this hook there is the layout settings, the layout plugin definition but not the layout plugin instance. So not possible to access third party settings.
I wonder if UI Styles data should then be stored inside the settings???
(I wanted to target something generic in preparation of refactoring, to avoid the hook_entity_view_alter())
- last update
over 1 year ago 54 pass - Status changed to Needs review
over 1 year ago 11:49am 7 August 2023 - Status changed to Needs work
over 1 year ago 12:32pm 7 August 2023 - 🇫🇷France Grimreaper France 🇫🇷
I will rework the form and configuration structure at the same time.
Otherwise it will require adaptations in gin_lb.
- last update
over 1 year ago 54 pass - Status changed to Needs review
over 1 year ago 1:52pm 7 August 2023 - 🇫🇷France Grimreaper France 🇫🇷
Finally, currently no config storage reorganisation.
-
Grimreaper →
committed 524b8827 on 8.x-1.x
Issue #3238226 by Grimreaper, pdureau: Apply styles to Layout Builder...
-
Grimreaper →
committed 524b8827 on 8.x-1.x
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 2:13pm 7 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.