The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- @timplunkett opened merge request.
- 🇺🇸United States tim.plunkett Philadelphia
Opened an MR with the code from #6
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
Thanks a lot for the issue and the work done here.
I am encountering the problem in https://www.drupal.org/project/ui_styles → for the sub modules.
Currently we have ui_styles_layout_builder that allows to add CSS classes to the rendering of blocks and layouts used in Layout Builder but on the long term we would like to have:
- ui_styles_block: for blocks either in Layout Builder or in Structure > block layout
- ui_styles_layout: for layouts anywhere it is used, Layout Builder, view modes, Page Manager, etc.And I think it may also introduce a great potential of refactoring of https://www.drupal.org/project/layout_options → to not have to provide a dedicated layout class.
I don't know if it is out-of-scope of this issue, currently the issue is focused on (sub)form alter / validation / submission. But what happens after new configuration is saved? How do I use generically the newly/altered configuration?
For blocks and layouts, it is the build() method that is used but it may have a different name in other plugin types. Maybe a first distinction could be "rendering" plugin types, and then the other plugin types?
The subject may be too massive and may have to be splitted into dedicated issues. First this one handling configuration form will be a huge step forward.