- πΊπΈUnited States cedewey Denver, CO
This is a great idea. I've added some detail to the proposed resolution.
- π§πͺBelgium dieterholvoet Brussels
Before anyone starts working on this, I have a basic implementation ready in a custom project we could use as a base.
- πΊπΈUnited States srdtwc Skokie, IL
@DieterHolvoet that would be great to see. I am hoping to have this done in the next couple of weeks if you are able to share what you have.
- π§πͺBelgium dieterholvoet Brussels
Here's the custom controller I have in my project: https://gist.github.com/DieterHolvoet/1804206bde05a3a2bed93925a5fc2071
The part reading Gin settings is for matching the embed theme with the Gin theme light/dark mode. Instead of providing the ability to paste the whole embed HTML, I would add a field for the auth code and build the embed yourself as in my example. The result will look better. - πΊπΈUnited States srdtwc Skokie, IL
Thanks for sharing! That's exactly the approach I was going to take, but I didn't think of using the light/dark settings from Gin. That's a nice touch.
I'll let you know if I have any questions
- π§πͺBelgium dieterholvoet Brussels
It might be a good idea to develop this with β¨ Add a block with an embed of the Plausible dashboard Active in mind, e.g. by abstracting away the embed building in a custom element that we can use in both use cases.
- @srdtwc opened merge request.
- πΊπΈUnited States srdtwc Skokie, IL
I've opened a merge request with this feature in place.
I've kept it pretty simple for now to make sure the basic functionality works.
- Status changed to Needs work
over 1 year ago 9:08pm 31 May 2023 - π§πͺBelgium dieterholvoet Brussels
Looks good! Didn't test it yet, but added some comments in the MR. Setting to Needs work.
- πΊπΈUnited States srdtwc Skokie, IL
Here is where I got the "system" setting
- πΊπΈUnited States srdtwc Skokie, IL
I chose to have the full "Shared link" instead of just the auth param because I thought that would be more user friendly. Plausible provides the full Shared Link, so someone can just copy/paste that into the module settings, rather than having to copy just the auth param component. That could be difficult for a non-technical user who doesn't know what that is.
We have many clients who are switching from Google Analytics to Plausible for its user friendliness so that's something I'd like to keep in mind.
- π§πͺBelgium dieterholvoet Brussels
You're right, the
system
value is correct. Must have got that wrong earlier and never noticed it. You're right about it being more user friendly to copy/paste the whole Shared url, I didn't think about that before. - πΊπΈUnited States srdtwc Skokie, IL
I have made the changes that you've requested as far as I've understood them. Sorry If there's anything I've missed.
The time I have been spending on this has come from a client project budget which is limited, so I don't think I am able to spend more time making feature enhancements. If you find any bugs in my code though I would be happy to address those.
- Status changed to Needs review
over 1 year ago 7:10pm 19 June 2023 - π§πͺBelgium dieterholvoet Brussels
@srdtwc could you give this a last round of testing before I merge it?
- πΊπΈUnited States srdtwc Skokie, IL
I just tested these changes out and everything appears to be working fine. I tried removing and adding a shared link, adding an invalid link, viewing the shared link route when no link was set and all behaviors are as expected.
Thank you for your assistance with this.
- Status changed to RTBC
over 1 year ago 7:19pm 19 June 2023 -
DieterHolvoet β
committed 78f16173 on 2.x authored by
srdtwc β
Issue #3232308 by srdtwc, DieterHolvoet: Add an admin page with an embed...
-
DieterHolvoet β
committed 78f16173 on 2.x authored by
srdtwc β
- Status changed to Fixed
over 1 year ago 7:35pm 19 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.