Single rule not working for multiple entities

While I still don't totally *like* the core logic and think it would need a nested decision tree instead, this should work like core and with the patch it does. RTBC!

Merged into 2.x, thank you @er.garg.karan!

And merged into 8.x-1.x-dev!

In 8.x we defined one rule and only a 'Request Pad': /admin123 /* Our module used the alternative theme. Simple but it worked fine.
Now we installed 2.x in our test environment and received only a form from the front page with a update menu. Tried everything, even two rules. Only after we restore the original version from the patch above it worked again. Can you explain this? Thanks.
(Drupal 9.5.5, PHP 8.1)

@jefw: Could you please try to revert the "or" to "and" in the 2.x version in your testing environment?
Means: just revert the change from this commit: https://git.drupalcode.org/project/theme_switcher/-/commit/41c44b31efdaf... locally / manually.

Then we can be sure this is the reason!

If it's not, please create a separate issue and provide screenshots. If it's the reason, I think we should revert the change made here and have a look again with @er.garg.karan and ckng.

Would be great if anyone could invest or sponsor time to write tests...

i did what you asked. I notice that the error only occurs after selecting user roles.
Here is a print screen of what I get.
(sorry, i don't now how to make a new issue)

@jefw so if you switch 'or' back to 'and', does it work like before?

Yes, attached the normal front page.
the error only occurs with a login form the selected user roles.

Automatically closed - issue fixed for 2 weeks with no activity.

When switching to Drupal 10 and theme_switcher 2.0.1. All the admin pages where now using the front theme.
Even if my URL path where only 3 specific admin pages and not all of them.

I switch it back from 'or' to 'and' and this solve the issue. So now the rules from version 1 are working identical with version 2.

Same here. Updating from 1.x to 2.x breaks the entire theme switching. We have about 20 rules and whatever rule we put on top, the first one is selected and evaluates to true. Switching back to "or" solves the issue.

I checked our existing rules. They combine different conditions and expect "and" as conjunction.

✨ Conjunction and/or should be configurable Fixed should solve this issue.

Automatically closed - issue fixed for 2 weeks with no activity.