- π§πͺBelgium tim-diels Belgium π§πͺ
Hi, you're correct. We should have added the update. Hereby the patch containing the update.
- Status changed to Needs work
almost 2 years ago 4:20pm 1 February 2023 - πΊπΈUnited States smustgrave
Think this will need some work. Title is showing as details vs the field label and attached screenshot you can see this broke styling. This was on claro.
- π¨π¦Canada bgilhome Victoria
Here's the patch re-rolled from current 1.x-dev.
- Status changed to Needs review
about 1 year ago 12:37pm 22 September 2023 - π§πͺBelgium tim-diels Belgium π§πͺ
Works on 2.x also and should be the way forward to include it on 2.x.
@smustgrave could you give a screenshot of the source where there is both a details that is correct and incorrect?
I'm using this on Gin theme and that works out of the box for us. But I do see there are missing classes, for example field-group-details so could be that there is the problem. I do however don't see that we need to add this as an attribute if I look at core.
But I think we should refactor the'#type' => 'container'
to'#type' => 'fieldset'
when not using the details element. - Status changed to Needs work
about 1 year ago 2:36pm 5 October 2023 - πΊπΈUnited States smustgrave
Unchecking "use details" removes the field from the right sidebar and into the center column. Don't think that's desired, if a user wants to update the form in that way they can use a custom hook.
FWIW I'm using patch 6 successfully, and find this behavior useful/desirable. (moving the field from the sidebar into the center column)
- Status changed to Needs review
10 months ago 6:43pm 1 February 2024 - πΊπΈUnited States smustgrave
Fixed issue where details wasn't rendering correct on right sidebar.
-
smustgrave β
committed 563d1ec7 on 3.0.x
Resolve #3227029 "Add option to"
-
smustgrave β
committed 563d1ec7 on 3.0.x
- Status changed to Fixed
10 months ago 10:39pm 1 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.