Activate tab by link anchor is broken

Here is a rerolled version of the patch in #4 for the 3.4 version

I noticed a typo in that last patch. I don't know if it breaks in all instances, or just mine. When I fixed the typo I was able to use the /node/add/bill#edit-group-path in the 8.x-3.6.

if (hash !== '#' && $(hash, <strong>this</strong>).length) {
  tabFocus = $(hash, <strong>this</strong>).closest('.horizontal-tabs-pane');
} else {
  tabFocus = $this.find('> .horizontal-tabs-pane:first');
}bFocus = $this.find('> .horizontal-tabs-pane:first');
}

the two instances of this should be $this.

This typo is present in 8.x-3.6 and 3.x-dev

#7: According to jquery docs that should not matter.
https://api.jquery.com/jQuery/

I can confirm that #6 applies to current version and fixes the issue for me.

Conflicts need to be resolved, then we need RTBC again. Please use the MR.

Here is a new version of the patch from #6 for the 4.x version

idimopoulos → made their first commit to this issue’s fork.

I have rerolled the patch and added a test for each case.
However, I extended the MR to also include an update to the location hash. I don't see the point of having the ability to work when manually adding the fragment but not being able to see it when clicking the tabs.

Disclaimer though: Feel free to disagree and remove the last commit.

I confirm the issue is present in 4.x and the code in the MR fixes it.

Thank You, I can also confirm MR539983 works as expected.

Still needs tests ad there's an unresolved comment.

I see, also I have notice, that my web pages where "field group" is used is slower now. Does anyone experience the same issue after applied this patch?