- Merge request !5Issue #3226844: Activate tab by link anchor is broken → (Open) created by eric.chenchao
- last update
almost 2 years ago 17 pass Here is a rerolled version of the patch in #4 for the 3.4 version
- 🇺🇸United States david.harris@metrostate.edu
I noticed a typo in that last patch. I don't know if it breaks in all instances, or just mine. When I fixed the typo I was able to use the /node/add/bill#edit-group-path in the 8.x-3.6.
if (hash !== '#' && $(hash, <strong>this</strong>).length) { tabFocus = $(hash, <strong>this</strong>).closest('.horizontal-tabs-pane'); } else { tabFocus = $this.find('> .horizontal-tabs-pane:first'); }bFocus = $this.find('> .horizontal-tabs-pane:first'); }
the two instances of this should be $this.
This typo is present in 8.x-3.6 and 3.x-dev
- 🇩🇪Germany geek-merlin Freiburg, Germany
#7: According to jquery docs that should not matter.
https://api.jquery.com/jQuery/ - Status changed to RTBC
10 months ago 4:21pm 24 August 2024 - 🇩🇪Germany geek-merlin Freiburg, Germany
I can confirm that #6 applies to current version and fixes the issue for me.
- Status changed to Needs work
10 months ago 7:01am 8 September 2024 - 🇩🇪Germany Anybody Porta Westfalica
Conflicts need to be resolved, then we need RTBC again. Please use the MR.
- 🇳🇱Netherlands anneke_vde
Here is a new version of the patch from #6 for the 4.x version
- 🇬🇷Greece idimopoulos
idimopoulos → made their first commit to this issue’s fork.
- 🇬🇷Greece idimopoulos
I have rerolled the patch and added a test for each case.
However, I extended the MR to also include an update to the location hash. I don't see the point of having the ability to work when manually adding the fragment but not being able to see it when clicking the tabs.Disclaimer though: Feel free to disagree and remove the last commit.
- 🇷🇴Romania andras_szilagyi
I confirm the issue is present in 4.x and the code in the MR fixes it.