Link for 'All items in Glossary AZ' doesn't cleanup the facet and appends the All facet value to the url several times

Created on 4 August 2021, over 3 years ago
Updated 27 June 2023, over 1 year ago

Problem/Motivation

When a facet in the glossary is already selected for filtering, the 'All' facet does not display all the results. Among that, one new duplicated 'All' parameter is appended to the 'All' link url every time you click on it.

Steps to reproduce

When the option 'All items in Glossary AZ' is selected, the facet renders a link with the 'All' option to display all results for the facet. Initially, the facet links to the current page with no parameters, and is flagged as active, which is the expected behavior.
Then, If you click in another glossary item, the filter works, but the 'All' facet change its url with a param appending the 'All' facet value. Clicking on it, does no filtering and then, the All facet value is appended again (twice) to the url of the 'All' link. This behavior can be reproduced several times, produced several 'All' params being appended to the url of the 'All' link

Proposed resolution

Initialize the All facet value using NULL as raw value.
See https://git.drupalcode.org/project/facets/commit/21343a6#32b7c8f64e3ecdb...

Remaining tasks

  • Test
  • Review

User interface changes

None

API changes

None

Data model changes

🐛 Bug report
Status

Needs work

Version

4.0

Component

User interface

Created by

🇪🇸Spain akalam

Live updates comments and jobs are added and updated live.
  • Needs manual testing

    The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

  • Needs screenshots

    The change alters the user interface, so before and after screenshots should be added to document the UI change. Make sure to capture the relevant region only. Use a tool such as Aviary on Windows or Skitch on Mac OS X.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Status changed to Needs work almost 2 years ago
  • 🇬🇧United Kingdom miteshmap

    I have rebased the patch again on the latest version, but the patch doesn't clean up the urls and doesn't work as expected.

  • 🇫🇷France eddylbs Paris

    Good morning,

    I found the solution to this problem by placing "URL handler" in the first position in the "Build stage" section of the advanced settings of the facet configuration

Production build 0.71.5 2024