Only render the view title if the 'Include view title' plugin is enabled

Composer fails to merge patch in #11 current dev. Attached patch fixes that.

Here's another updated patch for more updates in dev.

The last submitted patch, 16: viewsreference-view-title-display-3224064-16.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Hi Tried patch #15 but it did not work. In version 2.0 we don't have the option like 1.8 for the "Include View Title" on the specific content level.

Same problem as number #18, the option to deactivate the title does not appearSame problem as number 18, the option to deactivate the title does not appear

I recreated my patch based on #11 🐛 View title is always displayed if the extra setting is hidden Needs work , so the missing option should be there.

The last submitted patch, 20: viewsreference-view-title-display-3224064-20.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Here's patch #20 again, this time with the PHP CodeSniffer issues resolved.

The last submitted patch, 23: viewsreference-view-title-display-3224064-23.patch, failed testing. View results →

Same problem here on 2.0.beta7, resolved by adding a title display settings verification (check also that your field formatter settings has always the title display option to false ), that worked for me.

Sorry I made a mistake during the previous patch generation. Please ignore it and try this one.

Hi daisyleroy, facing this issue: "$this" can no longer be used in a plain function or method since PHP 7.1 while applying patch #26 on this 2.0.beta7 version..

Updated the patch by fixing this issue: $this" can no longer be used in a plain function or method since PHP 7.1 now able to apply on 2.0.beta7..

There is some much deeper problem here, something is very wrong with the functionality and storage of this option in 2.0-beta7

In the field settings, the title value can not be saved at all. I guess there is an incorrect schema:

viewsreference.schema.yml

field.field_settings.viewsreference:
  type: mapping
  label: 'Viewsreference field settings'
  mapping:
    enabled_settings:
      type: sequence
      label: 'Enabled settings'
      sequence:
        type: viewsreference.enabled_settings.[%key]

viewsreference.enabled_settings.title:
  type: boolean
  label: 'Include View Title settings'

However, in the field config we see this structure:

field.field.ENTITY.FIELDNAME.yml

settings:
  enabled_settings:
    argument: argument
    pager: pager
    title: true <--- this does not look correct here, I believe the value should be 'title' here

I also tried manually hacking the config value to 'title' and then importing, but the display title option still was not rendered in the form.

I tested patch #28 and it did not have any noticeable effect on my site, did not change anything.

#25 mentions a field formatter / display setting. This setting was visible one time. But after changing settings in the field storage, the "display title" option in the field formatter / display setting was gone forever (tried removing and re-patching, but the display option in the field formatter was lost). I also don't understand why a field formatter option is necessary at all, when this feature exposes that setting to the editor.

To me it seems all the patches miss the problem. In regard of title display:
- none of the patches here for 2.0-beta7 works
- 2.0-beta6 works
- using 2.0-beta7 without any of the patches here and simply manually deleting the schema file works

I'm closing this issue in favor of issue 3402036 🐛 Configuration schema for "Enable extra settings" (title,pagination,...) incorrect Fixed .

If you are using 2.0-beta7 and have problems with the views title display, use the patch the issue linked above.

The issue summary was quite a bit out of date as are earlier screenshots of the UI. I updated it to match the current state. Re-opening this as the current state still shows the view title view plugin regardless of whether the plugin is enabled or not. This is because this plugin is loaded differently compared to plugins that affect the view itself: this plugin is loaded above the render of the view with its own unique code to load it.

Patch doesn't work.

Patch should work now. Could you please confirm?
Test coverage also added.

So current situation with this MR is now:

1. 'Include the view title' plugin not enabled on the field: No title shown
2. 'Include the view title' plugin is enabled on the field: Checkbox unchecked: No title shown
3. 'Include the view title' plugin is enabled on the field: Checkbox checked: Title shown

Updated patch for the 8.x-2.0-beta10

Updated the merge request to merge in the latest 2.x changes.

Can't use a patch file generated from that with composer as it includes modifications to the tests directory contents which is actually specified in the .gitattributes file to export-ignore:

/tests export-ignore

So to use this currently (on beta10) (before this MR is hopefully merged in at some point), you'll need to use the patch here made by @ershov.andrey.

I can confirm the changes do what @scott_euser states in comment 36, marking as RTBC.