Contrib.social

FileSystem::copy() doesn't state $replace param is optional

Open on Drupal.org →
Created on 8 July 2021, over 3 years ago
Updated 14 July 2024, 5 months ago

Problem/Motivation

API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21File%21Fi...

The $replace param should be marked as optional by prefixing the description with '(optional)', and the default value specified.

Proposed resolution

Adds the coder rule in phpcs.xml and fix all of problems in all files.

Remaining tasks

  • Read the meta related issue following @larowlan's instructions in #9 to see if this should be closed as a duplicate, and if not, then update the issue summary to clearly update that. "We scope by PHPCS rule, not by file/module etc. So if missing (optional) is indeed a PHPCS failure, then we need to
    • make sure that coder can detect it.
    • make sure there's no existing issue in the meta to fix it
    • add a new issue as a child of the meta
    • enable the coder rule in phpcs.xml
    • fix it everywhere in core, and only that rule"
  • Update the issue fork branch with the latest work.
  • Fix remaining issues following the resolution steps above.
🐛 Bug report
Status

Closed: outdated

Version

11.0 🔥

Component
Documentation  →

Last updated 1 day ago

No maintainer
Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024