Contrib.social

Arguments not passed to ViewContent->render

Open on Drupal.org →
Created on 21 June 2021, almost 4 years ago
Updated 22 May 2024, about 1 year ago

In ViewContent->render, we collect and process the arguments passed into the view here:

$args = empty($options['args']) ? [] : array_map('trim', explode('/', $options['args']));

but when we check to see if the view has results, we don't pass in the arguments:

$view_results = views_get_view_result($options['vid'], $options['display']);
    if (!$view_results && !empty($options['vid']) && !empty($options['display'])) {

If you're using arguments in the view, this could easily incorrectly display an empty view. Incoming patch to pass the arguments into the view_results check, if set.

🐛 Bug report
Status

Needs work

Component

Code

Created by

🇬🇧United Kingdom peter.thorndycraft

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 year ago →
    Anwaikurn

    The patch #2 looks good but does not account for the processing of attached display arguments, so it needs improvement.

  • Merge request !20Resolve #3219839 "Arguments not passed" → (Open) created by Anwaikurn
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    2 pass
  • Pipeline finished with Failed
    about 1 year ago
    Total: 180s
    #179755
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    Patch Failed to Apply
  • Comment about 1 year ago →
    Anwaikurn

    Added patch for 8.x-3.0-alpha7.

  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇺🇸United States smustgrave

    Lets add some test coverage.

  • First commit to issue fork.
  • Merge request !34Resolve #3219839 "Arguments not passed 4.0.x" → (Open) created by mradcliffe
  • Pipeline finished with Success
    4 months ago
    Total: 167s
    #403836
  • Pipeline finished with Success
    about 1 month ago
    Total: 270s
    #473169
  • Pipeline finished with Success
    15 days ago
    Total: 235s
    #491811
  • Comment 15 days ago →
    Anwaikurn

    I was working on my local project with this patch applied and found that Views with customized header/footer/empty handlers are ignored and counted as empty because the algorithm checks only $view->result, but not any additional handlers.

    It seems like this issue was partially found earlier in this comment → , but it has no fixes, or maybe I missed a separate issue that resolved it.

    - If a View's Empty Behavior is set, the output is never displayed even if "Hide empty tabs" isn't selected.

    I fixed this issue in the new commit.

  • Comment 15 days ago →
    🇺🇸United States mradcliffe USA

    There's some new phpcs issues introduced, but otherwise I think the changes make sense. I added needs tests based on #10.

  • Pipeline finished with Success
    15 days ago
    Total: 173s
    #492240
  • Comment 15 days ago →
    Anwaikurn

    Fixed phpcs issues, also deleted unnecessary arguments unset in executeView() that cause missing view content.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024