The patch #2 looks good but does not account for the processing of attached display arguments, so it needs improvement.
- last update
about 1 year ago 2 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:21pm 22 May 2024 - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs work
5 months ago 6:11pm 10 December 2024 - First commit to issue fork.
I was working on my local project with this patch applied and found that Views with customized header/footer/empty handlers are ignored and counted as empty because the algorithm checks only $view->result, but not any additional handlers.
It seems like this issue was partially found earlier in this comment β , but it has no fixes, or maybe I missed a separate issue that resolved it.
- If a View's Empty Behavior is set, the output is never displayed even if "Hide empty tabs" isn't selected.
I fixed this issue in the new commit.
- πΊπΈUnited States mradcliffe USA
There's some new phpcs issues introduced, but otherwise I think the changes make sense. I added needs tests based on #10.
Fixed phpcs issues, also deleted unnecessary arguments unset in executeView() that cause missing view content.